Cacti – Formatting Guidelines

# Formatting Guidelines

## Overview

Over the years Cacti has attempted to adhere to standards in code construction, syntax, style, etc. It has been a very organic grow which has resulted in some mixed styles. Cacti is in the process of moving to PHP Standards Recommendations (PSR) standards.

Initially we are moving towards PSR-2 code syntax standard with the following exceptions:

- Initial white space must be tabs not spaces followed by the use of spaces to align elements after initial tab.

- In a block of variable assignments or array elements (moved to multi-line) it is acceptable, but not required, to use spaces to align the `=` or `=>` for the purpose of readability.

- Bracketing/braces should start on the same line of the statement. For example:

  - `if (expression) {`,
  - `} else {`,
  - and `} elseif {`

- Use lower case constants for things like `false`, `true`, and `null`.

- Use `print` over `echo`.

- Function declarations should include ending braces on the same line as the function. For example:

  - `function name($params ...) {`

- White-space inside of evaluations is discouraged. For example:

  - `if (expression) {` and not `if ( expression ) {`.

- Using single quotes to enclose strings, and arrays. This save quite a bit of page processing time. Use of double quotes is acceptable in certain circumstances.

All style guidelines should be followed exactly as shown in these examples, unless indicated otherwise.

## Indenting

Very simply, always use tabs to indent rather than spaces. Tab stops should be set to 4 spaces.

Below are the vim rules to accomplish this:

    set expandtab
    set shiftwidth=4
    set softtabstop=4
    set tabstop=4

## Control Structures

Use the following style guidelines for control structures.

### if elseif else Construct

    if ($var == 0) {
        $i++;
    } elseif ($var == 1) {
        $i--;
    } else {
        $i = 0;
    }

### switch Construct

    switch ($var) {
        case 0:
            $var = 1;

            break;
        case 1:
            $var = 2;

            break;
        default:
            $var = 3;

            break;
    }

### while Loop

    while ($i < 10) {
        $i++;
    }

### for Loop

    for ($i = 0; $i < 10; $i++) {
        $var *= 6;
    }

### foreach Loop

    foreach ($array as $key => $value) {
        print "$key = $value\n";
    }

## Naming

### General Function Naming

All function names should begin with an identifier (see below) and end with an action. The identifier should generally be derived from the name of the file which the function resides.

`Returns all users`

    function user_list() {
        // code
    }

`Returns a specific user`

    function user_get($user_id) {
        // code
    }

`Returns the total number of graphs`

    function graph_total_get() {
        // code
    }

`Returns a specific graph title`

    function graph_title_get() {
        // code
    }

### Constant Naming

Constants should always be all capital letters. In most cases, they begin with some identifier. The name should be verbose enough that it describes exactly what the constant represents. Below is the general structure of the name.

`[identifier]_[type]_[value]`

`Supported graph rendering file types`

    define('GRAPH_IMAGE_TYPE_PNG', 1);
    define('GRAPH_IMAGE_TYPE_GIF', 2);

`Data input types for data sources`

    define('DATA_INPUT_TYPE_NONE', 1);
    define('DATA_INPUT_TYPE_DATA_QUERY', 2);
    define('DATA_INPUT_TYPE_SCRIPT', 3);
    define('DATA_INPUT_TYPE_SNMP', 4);

## Common Action Types

- list - an array of one or more items

- get - an array with one item or a single value (such as an integer or string)

- remove - some data is to be removed from the database

- update - some pre-existing data is to be updated

- insert - some new data to be saved

- print - information will be echoed to the screen/browser

- generate - data will be generated and returned

- format - data will be passed in, formatted, and then returned

## Formatting

### Argument Spacing

Always include a single space after each argument in a list except for the last one.

    function log_insert($facility, $severity, $message) {
        // code
    }

    log_insert(LOG_FACILITY_LOCAL0, LOG_LEVEL_WARNING, 'test message');

As a general rule of thumb, it is OK to include additional spaces where necessary to improve code readability. The key here is that writing readable code always takes priority.

### White space

Always place a single blank line after a control structure unless the following line is an ending brace `}`. There should be no blank lines at the end of the file, and no spaces at the end of line.

    if ($var == 0) {
        $i = 0;
    }

    if ($i == 0) {
        $i *= 2;
    }

    if ($var ==0) {
        if ($i == 2) {
            $i++;
        }
    }

## Storage Constructs

### Constants

Always use constants instead of numbers to represent static values. Instead of doing:

    if ($poller_verbosity == 2) {
        // code
    }

Do:

    if ($poller_verbosity == POLLER_VERBOSITY_LOW) {
        // code
    }

### Variables

Allocating memory for a variable consumes resources. Only declare a variable if it is referenced more than once throughout the code. Instead of doing:

    $num_devices = device_total_num_get();

    if ($num_devices > 0) {
        // code
    }

Do:

    if (device_total_num_get() > 0) {
        // code
    }

### Global Variables

Certain situations warrant creating a single variable that is to be referenced by multiple functions. Do not rely on PHP's `global` keyword since it creates the possibility of name space collisions. Instead, create a wrapper function that brings the variable into a global scope and returns a new copy to any function that needs to use it.

    $graph_unit_exponent_values = array(
      '-18' => 'a - atto',
      '-15' => 'f - femto',
      ...
    );

    function graph_unit_exponent_values_list() {
        global $graph_unit_exponent_values;

        return $graph_unit_exponent_values;
    }

    function graph_unit_exponent_values_print() {
        foreach (graph_unit_exponent_values_list() as $power => $unit) {
            // code
        }
    }

## References

Copying around large arrays in PHP can be an expensive operation. Be sure to return or pass arrays by reference when data corruption is not a huge concern.

    function big_array_process(&$big_array) {
        // code
    }

## Database Calls

Ensure that you indent your Database calls by a single tab per indentation level and that you break up database calls by the various provisos. A few well defined database queries can be seen in the examples below

    $devices = db_fetch_assoc_prepared('SELECT *
      FROM host
      WHERE id = ?',
      array($device_id));

    $vdefs = db_fetch_assoc("SELECT rs.*,
      SUM(CASE WHEN local_graph_id = 0 THEN 1 ELSE 0 END) AS templates,
      SUM(CASE WHEN local_graph_id > 0 THEN 1 ELSE 0 END) AS graphs
      FROM (
        SELECT vd.*, gti.local_graph_id
        FROM vdef AS vd
        LEFT JOIN graph_templates_item AS gti
        ON gti.vdef_id = vd.id
        GROUP BY vd.id, gti.graph_template_id, gti.local_graph_id
      ) AS rs
      $sql_where
      GROUP BY rs.id
      $sql_having
      $sql_order
      $sql_limit");

1. Ensure that you use prepared statements as in the first example whenever you can.

2. If you can not use prepared statements, ensure that you properly escape any database SQL WHERE logic properly.

3. Always use the term `AS` to define an alias.

4. Ensure that your JOINs are either INNER, LEFT, or RIGHT.

5. Ensure that the ON clause uses table aliases, and that each `AND` or `OR` expression is logically organized for easy reading and interpretation.

6. In your SQL WHERE and SELECT, where functions are involved

   1. Ensure that there are spaces between parameter
   2. Ensure operators and variables are separated by spaces

## Comments

The key to being a respectable coder is to write clear, concise code and to use comments everywhere.

### Whole Line Comments

All single and multi-line comments should follow the C-style syntax.

    /* this determines if $i is equal to 0 */
    if ($i == 0) {
        // code
    }

    /* this is an extra long comment that deserves to be
     * split up into multiple lines
     */
    if ($i == 0) {
        // code
    }

### End of Line Comments

Shorter comments that follow a line of code should use the familiar `//` style.

    $var = 0; // assign 0 to $var

### File Header Comments

All code related files must contain the following notice at the beginning of the file.

    /*
     +-------------------------------------------------------------------------+
     | Copyright (C) 2004-2023 The Cacti Group                                 |
     |                                                                         |
     | This program is free software; you can redistribute it and/or           |
     | modify it under the terms of the GNU General Public License             |
     | as published by the Free Software Foundation; either version 2          |
     | of the License, or (at your option) any later version.                  |
     |                                                                         |
     | This program is distributed in the hope that it will be useful,         |
     | but WITHOUT ANY WARRANTY; without even the implied warranty of          |
     | MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the           |
     | GNU General Public License for more details.                            |
     +-------------------------------------------------------------------------+
     | Cacti: The Complete RRDtool-based Graphing Solution                     |
     +-------------------------------------------------------------------------+
     | This code is designed, written, and maintained by the Cacti Group. See  |
     | about.php and/or the AUTHORS file for specific developer information.   |
     +-------------------------------------------------------------------------+
     | http://www.cacti.net/                                                   |
     +-------------------------------------------------------------------------+
    */

### Function Comments

All functions must be preceded by a comment describing the purpose, argument list, and return type of the function. It should be formatted per PHP DocBlock specifications as follow:

    /**
     * Makes a connection to the database server
     *
     * Given a set of login credentials, an attempt is made to establish a persistent database connection.
     * If the attempt fails, script execution will halt with an error.
     *
     * @param string $host the hostname of the database server, 'localhost' if the database server is running
     *   on this machine
     * @param string $user the username to connect to the database server as
     * @param string $pass the password to connect to the database server with
     * @param string $db_name the name of the database to connect to
     * @param string $db_type the type of database server to connect to, only 'mysql' is currently supported
     * @param int $retries the number a time the server should attempt to connect before failing
     *
     * @return bool true if successful, false otherwise
     */

Place a space between the `@param` and `@return`.

Copyright (c) 2004-2023 The Cacti Group